fix(cc-widgets): Add timeout inactivity properties to cc store#695
fix(cc-widgets): Add timeout inactivity properties to cc store#695zachraymer wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 258269f467
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| isTimeoutDesktopInactivityEnabled: profile.isTimeoutDesktopInactivityEnabled, | ||
| timeoutDesktopInactivityMins: profile.timeoutDesktopInactivityMins, |
There was a problem hiding this comment.
When AGENT_STATION_LOGIN_SUCCESS or relogin payloads omit these optional fields (the existing station-login success fixture in packages/contact-center/station-login/tests/helper.ts has no timeout fields), setAgentProfile is invoked after registerCC and these assignments overwrite the timeout values that were just loaded from the registration Profile with undefined. Consumers reading store.agentProfile after login will lose isTimeoutDesktopInactivityEnabled/timeoutDesktopInactivityMins; only replace these keys when the payload actually includes them, or fall back to the existing values.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
1 participant
COMPLETES # https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7907
This pull request addresses
Exposing the
isTimeoutDesktopInactivityEnabledandtimeoutDesktopInactivityMinsproperties on the agentConfig object from cc storeby making the following changes
adds the fields to the agentconfig object in the cc store and related types and adds unit tests
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.